Open
Conversation
Author
|
I have these things left which will be done today (monday 28/2)
|
…comments, made token secret
Author
I have some major issues with the chart and number of commits. I will ask in StackOverflow for some help with this. |
…ith position absolute
|
|
||
|
|
||
| /* TABLET */ | ||
| @media screen and (min-width: 667px) and (max-width: 1024px) { |
There was a problem hiding this comment.
I think it's enough with the min-width in tablet mode, cause your desktop starts with the min-width 1024 anyway, just a thought
NabeelMansour
left a comment
NabeelMansour
left a comment
There was a problem hiding this comment.
Overall excellent job Mathilda and specially the accordian effects on your repoes
|
|
||
|
|
||
| /* TABLET */ | ||
| @media screen and (min-width: 667px) and (max-width: 1024px) { |
There was a problem hiding this comment.
I think it's well suited with just adding the min-width: 667px and skip the 1024 in tablet mode, cause of in the desktop it starts with the 1024 anyway as you can see the desktop mode, just a thought.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.